Enable Form dbio for a list of fields from one table, allow delaying processing#993
Merged
Merged
Conversation
mdipierro
reviewed
Aug 14, 2025
|
|
||
| if not readonly and auto_process: | ||
| self.process() | ||
| if self.csrf_protection: |
Contributor
There was a problem hiding this comment.
Should this now always run after process() even if auto_process is False?
Contributor
Author
There was a problem hiding this comment.
Wait, no, I was right originally.
The original code looks like this:
if not readonly:
# [...]
if post_vars:
self.submitted = True
if not self.csrf_protection or self._verify_form(post_vars):
process = True
if process:
# [...]
if self.csrf_protection:
self._sign_form()We both probably got turned around by the if not self.csrf_protection - thats been moved into the new process method and rewritten to an early return ((not A) or B inverted to A and (not B))
So this is actually matching the original logic exactly. If CSRF is enabled, the form is always signed. What i can't say if that original logic was correct.
mdipierro
reviewed
Aug 14, 2025
|
|
||
| if not readonly and auto_process: | ||
| self.process() | ||
| if self.csrf_protection: |
Contributor
There was a problem hiding this comment.
Should this now always run after process() even if auto_process is False?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to write forms which act on a subset of fields like this:
but currently, this disabled
dbiodue to aif isinstance(table, list)check.But if all fields have the same table,
dbiois perfectly safe.Also, to allow more complex logic including potentially multiple forms on a single page (haven't tested this tho), this makes form processing its own method, analogous to Grid